Request Cachebuilder - #761
Open
bsofjan wants to merge 2 commits into
Open
Conversation
CJA18
reviewed
Sep 4, 2026
| } | ||
|
|
||
| detectcachetobuild:{ | ||
| latestcache:{cachename:"MyFirstCache"; |
There was a problem hiding this comment.
again, I don't see the cache always being named "MyFirstCache"?
CJA18
reviewed
Sep 4, 2026
| if[0 = count caches; :`cachename`newcache!(cachename,"_",string .z.P;1b)]; | ||
| cachewithmaxstarttime:starts ? max starts:cands!{get ` sv x,`start} each cands:key[d] where not `end in/: value d:caches!key each caches; | ||
| if[(not isRequest) and ("N"$.setter.cacheconfig.setter.interval) < .z.P - "P"$@[last "_" vs string cachewithmaxstarttime;13 16 19;:;"::."];:`cachename`newcache!(cachename,"_",string .z.P;1b)]; | ||
| :`cachename`newcache!(cachewithmaxstarttime;0b)}[] |
There was a problem hiding this comment.
extract this to a separate function, too messy in here
CJA18
reviewed
Sep 4, 2026
| if[latestcache[`newcache]; cachewithmaxstarttime:` sv maincachepath,`$latestcache[`cachename]] | ||
|
|
||
| componentcaches:` sv' cachewithmaxstarttime,/:key .setter.cacheconfig.componentCaches | ||
| incompletecomponentcaches:key[d2] where not `end in/: value d2:componentcaches!key each componentcaches |
CJA18
reviewed
Sep 4, 2026
| argpaths:` sv' maincachepath,'(key maincachepath) where (key maincachepath) like "AsyncCache*"; | ||
| maxstarttime:string first max "P"$-1#' "_" vs' string argpaths; | ||
| argwithmaxstarttime:first argpaths where argpaths like "*",maxstarttime; | ||
| args:: get ` sv argwithmaxstarttime,`args |
CJA18
reviewed
Sep 4, 2026
|
|
||
| // Mode of cache | ||
| main:{[args] | ||
| isRequest:: first `$(.Q.opt args)[`isRequest] |
There was a problem hiding this comment.
camelCase for this variable in several places needs to be changed
|
Similarly to the other PR, you need to add detailed notes, documentation and testing proof for this. It needs to be easy for anyone to implement and use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the request cachebuilder as part of Phase 3 of the Anycache Project Proposal.